[
https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380775#comment-16380775
]
Allen Wittenauer commented on SOLR-10912:
-----------------------------------------
Github PR support is sort of there.
test-patch does. It can take either a github PR directly on the command line or
passed via a JIRA. If it gets told to test a JIRA that references a github PR,
it will defer to the PR as the source of the patch. In other words, if a JIRA
issue references a github PR and has a patch attached, it will use the github
PR and ignore the attachments.
However!
The job on Jenkins that feeds test-patch is *NOT* github aware. The original
version was built before github integration existed. To make matters worse,
that code was locked away in a repository no one really had access to modify.
As of a month or so ago, that code is now part of Apache Yetus (
https://github.com/apache/yetus/blob/master/precommit/jenkins/jenkins-admin.py
), so there is an opportunity for us to fix this problem and add better
asf<->github integration.
> Adding automatic patch validation
> ---------------------------------
>
> Key: SOLR-10912
> URL: https://issues.apache.org/jira/browse/SOLR-10912
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Build
> Reporter: Mano Kovacs
> Priority: Major
> Attachments: SOLR-10912.ok-patch-in-core.patch,
> SOLR-10912.sample-patch.patch, SOLR-10912.solj-contrib-facet-error.patch
>
>
> Proposing introduction of automated patch validation, similar what Hadoop or
> other Apache projects are using (see link). This would ensure that every
> patch passes a certain set of criterions before getting approved. It would
> save time for developer (faster feedback loop), save time for committers
> (less step to do manually), and would increase quality.
> Hadoop is currently using Apache Yetus to run validations, which seems to be
> a good direction to start. This jira could be the board of discussing the
> preferred solution.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
