[
https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380464#comment-16380464
]
Steve Rowe commented on SOLR-10912:
-----------------------------------
bq. I'm confused what the state is right now. In JIRA I see these new workflow
states. Do they do anything right now, or not yet pending further TODOs above?
Not yet. I'm working on it.
bq. Will this feature support both JIRA attached patch files as well as linked
GitHub PRs (e.g. as seen here: SOLR-11976) ?
Attached JIRA patch files, yes. I don't know about GitHub PRs... [~manokovacs]
? (Note his todo item, which sounds like the answer is yes for PRs: "Verify
the test-patch with Github PR")
> Adding automatic patch validation
> ---------------------------------
>
> Key: SOLR-10912
> URL: https://issues.apache.org/jira/browse/SOLR-10912
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Build
> Reporter: Mano Kovacs
> Priority: Major
> Attachments: SOLR-10912.ok-patch-in-core.patch,
> SOLR-10912.sample-patch.patch, SOLR-10912.solj-contrib-facet-error.patch
>
>
> Proposing introduction of automated patch validation, similar what Hadoop or
> other Apache projects are using (see link). This would ensure that every
> patch passes a certain set of criterions before getting approved. It would
> save time for developer (faster feedback loop), save time for committers
> (less step to do manually), and would increase quality.
> Hadoop is currently using Apache Yetus to run validations, which seems to be
> a good direction to start. This jira could be the board of discussing the
> preferred solution.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
