[ 
https://issues.apache.org/jira/browse/LUCENE-8245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431455#comment-16431455
 ] 

Karl Wright edited comment on LUCENE-8245 at 4/9/18 10:52 PM:
--------------------------------------------------------------

[~ivera], that case should not occur.  The shared endpoint of two edges must 
either be in the +/- 1e-12 zone of main travel plane, or it's outside.  If it's 
within that zone, then BOTH edges should show up as an intersection candidate.

The tree structures underneath the edge iterator may be the problem, since I 
don't believe they include the necessary 1e-12 extra bounds needed to guarantee 
that we compute the intersection.  That's what I'm going to look for, since in 
the dump above it doesn't appear like we even consider more than one edge in 
the iterator.



was (Author: kwri...@metacarta.com):
[~ivera], that case should not occur.  The shared endpoint of two edges must 
either be in the +/- 1e-12 zone of main travel plane, or it's outside.  If it's 
within that zone, then BOTH edges should show up as an intersection candidate.

The tree structures underneath the edge iterator may be the problem, since I 
don't believe they include the necessary 1e-12 extra bounds needed to guarantee 
that we compute the intersection.  That's what I'm going to look for.


> GeoComplexPolygon fails when intersection of travel plane with edge is near 
> polygon point
> -----------------------------------------------------------------------------------------
>
>                 Key: LUCENE-8245
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8245
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/spatial3d
>            Reporter: Ignacio Vera
>            Assignee: Karl Wright
>            Priority: Major
>             Fix For: 6.7, 7.4, master (8.0)
>
>         Attachments: LUCENE-8245-case2.patch, LUCENE-8245.jpg, 
> LUCENE-8245.patch
>
>
> When a travel plane crosses an edge close to an edge point , it is possible 
> that the above and below planes crosses different edges. In the current 
> implementation one of the crosses is missed because we only check edges that 
> are crossed by the main plain and the {{within}} result is wrong.
> One possible fix is to check always the intersection of planes and edges 
> regardless if they are crossed by main plane. That fixed the above issue but 
> shows other issues like travel planes crossing two edges when it should be 
> only one due to the fuzziness at edge intersections.
> Not sure of a fix so I add the test showing the issue.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to