[
https://issues.apache.org/jira/browse/LUCENE-8245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437290#comment-16437290
]
Steve Rowe edited comment on LUCENE-8245 at 4/13/18 1:35 PM:
-------------------------------------------------------------
*edit*: I see LUCENE-8251 has been opened for the failing test below:
Reproducing seed for {{RandomGeoPolygonTest.testComparePolygons()}} from
[https://jenkins.thetaphi.de/job/Lucene-Solr-7.x-Windows/545/]; reproduces for
me on Linux:
{noformat}
Checking out Revision 21f39627624fe4d2b80ca85fae8fdf2b26fd70b6
(refs/remotes/origin/branch_7x)
[...]
[junit4] 2> NOTE: reproduce with: ant test
-Dtestcase=RandomGeoPolygonTest -Dtests.method=testComparePolygons
-Dtests.seed=D6349E776359D46D -Dtests.slow=true -Dtests.locale=ms
-Dtests.timezone=Asia/Makassar -Dtests.asserts=true -Dtests.file.encoding=Cp1252
[junit4] FAILURE 0.15s J0 | RandomGeoPolygonTest.testComparePolygons
{seed=[D6349E776359D46D:C13F762B72BE3163]} <<<
[junit4] > Throwable #1: java.lang.AssertionError:
[junit4] > Standard polygon: GeoCompositePolygon: {[GeoConvexPolygon:
{planetmodel=PlanetModel.WGS84, points=[[lat=-0.07623836285341265,
lon=0.00454700984778178([X=0.998181035951336, Y=0.004538770280526402,
Z=-0.07624825759433645])], [lat=-7.476157549743229E-245,
lon=0.0([X=1.0011188539924791, Y=0.0, Z=-7.484522278466162E-245])],
[lat=0.001511171483804436, lon=-9.688787797923482E-4([X=1.001117233304039,
Y=-9.699615469421312E-4, Z=0.0015128616766053018])], [lat=-0.01412589292926225,
lon=-0.004052102300342142([X=1.0010100824418215, Y=-0.004056217458151357,
Z=-0.01414121792996793])]], internalEdges={}}]}
[junit4] > Large polygon: GeoComplexPolygon:
{planetmodel=PlanetModel.WGS84, number of shapes=1, address=b597f211,
testPoint=[lat=-0.02220757682746917,
lon=-1.218087190149091E-4([X=1.000870329530105, Y=-1.2191473334305646E-4,
Z=-0.02223055955204728])], testPointInSet=true, shapes={
{[lat=-0.01412589292926225, lon=-0.004052102300342142([X=1.0010100824418215,
Y=-0.004056217458151357, Z=-0.01414121792996793])], [lat=-0.07623836285341265,
lon=0.00454700984778178([X=0.998181035951336, Y=0.004538770280526402,
Z=-0.07624825759433645])], [lat=-7.476157549743229E-245,
lon=0.0([X=1.0011188539924791, Y=0.0, Z=-7.484522278466162E-245])],
[lat=0.001511171483804436, lon=-9.688787797923482E-4([X=1.001117233304039,
Y=-9.699615469421312E-4, Z=0.0015128616766053018])]}}
[junit4] > Point: [lat=3.310332671314249E-4,
lon=-3.0E-323([X=1.0011187987699837, Y=-3.0E-323, Z=3.314036388489196E-4])]
[junit4] > WKT: POLYGON((0.2605244736823189 -4.368136428487497,0.0
-4.283522745751538E-243,-0.05551266494188662
0.08658374814251642,-0.23216835996485705 -0.8093540467004184,0.2605244736823189
-4.368136428487497))
[junit4] > WKT: POINT(-1.7E-321 0.018966809085057403)
[junit4] > normal polygon: false
[junit4] > large polygon: true
[junit4] > at
__randomizedtesting.SeedInfo.seed([D6349E776359D46D:C13F762B72BE3163]:0)
[junit4] > at
org.apache.lucene.spatial3d.geom.RandomGeoPolygonTest.testComparePolygons(RandomGeoPolygonTest.java:179)
[junit4] > at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[junit4] > at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[junit4] > at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[junit4] > at
java.base/java.lang.reflect.Method.invoke(Method.java:564)
[junit4] > at java.base/java.lang.Thread.run(Thread.java:841)
[junit4] 2> NOTE: test params are: codec=Lucene70,
sim=RandomSimilarity(queryNorm=false): {}, locale=ms, timezone=Asia/Makassar
[junit4] 2> NOTE: Windows 10 10.0 amd64/Oracle Corporation 11-ea
(64-bit)/cpus=3,threads=1,free=73360360,total=97320960
{noformat}
was (Author: steve_rowe):
Reproducing seed for {{RandomGeoPolygonTest.testComparePolygons()}} from
[https://jenkins.thetaphi.de/job/Lucene-Solr-7.x-Windows/545/]; reproduces for
me on Linux:
{noformat}
Checking out Revision 21f39627624fe4d2b80ca85fae8fdf2b26fd70b6
(refs/remotes/origin/branch_7x)
[...]
[junit4] 2> NOTE: reproduce with: ant test
-Dtestcase=RandomGeoPolygonTest -Dtests.method=testComparePolygons
-Dtests.seed=D6349E776359D46D -Dtests.slow=true -Dtests.locale=ms
-Dtests.timezone=Asia/Makassar -Dtests.asserts=true -Dtests.file.encoding=Cp1252
[junit4] FAILURE 0.15s J0 | RandomGeoPolygonTest.testComparePolygons
{seed=[D6349E776359D46D:C13F762B72BE3163]} <<<
[junit4] > Throwable #1: java.lang.AssertionError:
[junit4] > Standard polygon: GeoCompositePolygon: {[GeoConvexPolygon:
{planetmodel=PlanetModel.WGS84, points=[[lat=-0.07623836285341265,
lon=0.00454700984778178([X=0.998181035951336, Y=0.004538770280526402,
Z=-0.07624825759433645])], [lat=-7.476157549743229E-245,
lon=0.0([X=1.0011188539924791, Y=0.0, Z=-7.484522278466162E-245])],
[lat=0.001511171483804436, lon=-9.688787797923482E-4([X=1.001117233304039,
Y=-9.699615469421312E-4, Z=0.0015128616766053018])], [lat=-0.01412589292926225,
lon=-0.004052102300342142([X=1.0010100824418215, Y=-0.004056217458151357,
Z=-0.01414121792996793])]], internalEdges={}}]}
[junit4] > Large polygon: GeoComplexPolygon:
{planetmodel=PlanetModel.WGS84, number of shapes=1, address=b597f211,
testPoint=[lat=-0.02220757682746917,
lon=-1.218087190149091E-4([X=1.000870329530105, Y=-1.2191473334305646E-4,
Z=-0.02223055955204728])], testPointInSet=true, shapes={
{[lat=-0.01412589292926225, lon=-0.004052102300342142([X=1.0010100824418215,
Y=-0.004056217458151357, Z=-0.01414121792996793])], [lat=-0.07623836285341265,
lon=0.00454700984778178([X=0.998181035951336, Y=0.004538770280526402,
Z=-0.07624825759433645])], [lat=-7.476157549743229E-245,
lon=0.0([X=1.0011188539924791, Y=0.0, Z=-7.484522278466162E-245])],
[lat=0.001511171483804436, lon=-9.688787797923482E-4([X=1.001117233304039,
Y=-9.699615469421312E-4, Z=0.0015128616766053018])]}}
[junit4] > Point: [lat=3.310332671314249E-4,
lon=-3.0E-323([X=1.0011187987699837, Y=-3.0E-323, Z=3.314036388489196E-4])]
[junit4] > WKT: POLYGON((0.2605244736823189 -4.368136428487497,0.0
-4.283522745751538E-243,-0.05551266494188662
0.08658374814251642,-0.23216835996485705 -0.8093540467004184,0.2605244736823189
-4.368136428487497))
[junit4] > WKT: POINT(-1.7E-321 0.018966809085057403)
[junit4] > normal polygon: false
[junit4] > large polygon: true
[junit4] > at
__randomizedtesting.SeedInfo.seed([D6349E776359D46D:C13F762B72BE3163]:0)
[junit4] > at
org.apache.lucene.spatial3d.geom.RandomGeoPolygonTest.testComparePolygons(RandomGeoPolygonTest.java:179)
[junit4] > at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[junit4] > at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[junit4] > at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[junit4] > at
java.base/java.lang.reflect.Method.invoke(Method.java:564)
[junit4] > at java.base/java.lang.Thread.run(Thread.java:841)
[junit4] 2> NOTE: test params are: codec=Lucene70,
sim=RandomSimilarity(queryNorm=false): {}, locale=ms, timezone=Asia/Makassar
[junit4] 2> NOTE: Windows 10 10.0 amd64/Oracle Corporation 11-ea
(64-bit)/cpus=3,threads=1,free=73360360,total=97320960
{noformat}
> GeoComplexPolygon fails when intersection of travel plane with edge is near
> polygon point
> -----------------------------------------------------------------------------------------
>
> Key: LUCENE-8245
> URL: https://issues.apache.org/jira/browse/LUCENE-8245
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/spatial3d
> Reporter: Ignacio Vera
> Assignee: Karl Wright
> Priority: Major
> Fix For: 6.7, 7.4, master (8.0)
>
> Attachments: LUCENE-8245-case2.patch, LUCENE-8245.jpg,
> LUCENE-8245.patch, LUCENE-8245.patch, LUCENE-8245_Polygon.patch,
> LUCENE-8245_Random.patch, LUCENE-8245_case3.patch
>
>
> When a travel plane crosses an edge close to an edge point , it is possible
> that the above and below planes crosses different edges. In the current
> implementation one of the crosses is missed because we only check edges that
> are crossed by the main plain and the {{within}} result is wrong.
> One possible fix is to check always the intersection of planes and edges
> regardless if they are crossed by main plane. That fixed the above issue but
> shows other issues like travel planes crossing two edges when it should be
> only one due to the fuzziness at edge intersections.
> Not sure of a fix so I add the test showing the issue.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
