[ 
https://issues.apache.org/jira/browse/LUCENE-8245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432269#comment-16432269
 ] 

Mikhail Khludnev edited comment on LUCENE-8245 at 4/10/18 1:42 PM:
-------------------------------------------------------------------

Hello, 
I'm afraid it may hurt precommit like 
https://jenkins.thetaphi.de/job/Lucene-Solr-7.x-Solaris/551/ 
{quote}
[forbidden-apis] Forbidden method invocation: java.lang.Math#toDegrees(double) 
[Use home-grown methods instead]
[forbidden-apis]   in org.apache.lucene.spatial3d.geom.RandomGeoPolygonTest 
(RandomGeoPolygonTest.java:177)
[forbidden-apis] Forbidden method invocation: java.lang.Math#toDegrees(double) 
[Use home-grown methods instead]
[forbidden-apis]   in org.apache.lucene.spatial3d.geom.RandomGeoPolygonTest 
(RandomGeoPolygonTest.java:177)
[forbidden-apis] Forbidden method invocation: java.lang.Math#toDegrees(double) 
[Use home-grown methods instead]
[forbidden-apis]   in org.apache.lucene.spatial3d.geom.RandomGeoPolygonTest 
(RandomGeoPolygonTest.java:214)
[forbidden-apis] Forbidden method invocation: java.lang.Math#toDegrees(double) 
[Use home-grown methods instead]
[forbidden-apis]   in org.apache.lucene.spatial3d.geom.RandomGeoPolygonTest 
(RandomGeoPolygonTest.java:214)
[forbidden-apis] Forbidden method invocation: java.lang.Math#toDegrees(double) 
[Use home-grown methods instead]
[forbidden-apis]   in org.apache.lucene.spatial3d.geom.RandomGeoPolygonTest 
(RandomGeoPolygonTest.java:216)
[forbidden-apis] Forbidden method invocation: java.lang.Math#toDegrees(double) 
[Use home-grown methods instead]
[forbidden-apis]   in org.apache.lucene.spatial3d.geom.RandomGeoPolygonTest 
(RandomGeoPolygonTest.java:216)
{quote}



was (Author: mkhludnev):
Hello, 
I'm afraid it may hurt precommit like 
https://jenkins.thetaphi.de/job/Lucene-Solr-7.x-Solaris/551/ 


> GeoComplexPolygon fails when intersection of travel plane with edge is near 
> polygon point
> -----------------------------------------------------------------------------------------
>
>                 Key: LUCENE-8245
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8245
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/spatial3d
>            Reporter: Ignacio Vera
>            Assignee: Karl Wright
>            Priority: Major
>             Fix For: 6.7, 7.4, master (8.0)
>
>         Attachments: LUCENE-8245-case2.patch, LUCENE-8245.jpg, 
> LUCENE-8245.patch, LUCENE-8245_Polygon.patch, LUCENE-8245_Random.patch, 
> LUCENE-8245_case3.patch
>
>
> When a travel plane crosses an edge close to an edge point , it is possible 
> that the above and below planes crosses different edges. In the current 
> implementation one of the crosses is missed because we only check edges that 
> are crossed by the main plain and the {{within}} result is wrong.
> One possible fix is to check always the intersection of planes and edges 
> regardless if they are crossed by main plane. That fixed the above issue but 
> shows other issues like travel planes crossing two edges when it should be 
> only one due to the fuzziness at edge intersections.
> Not sure of a fix so I add the test showing the issue.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to