[ 
https://issues.apache.org/jira/browse/SOLR-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062012#comment-13062012
 ] 

Mark Miller commented on SOLR-2633:
-----------------------------------

The heck if I know.

The comment says:

{code}
  /**
   * Sets the alternate path for multicore handling:
   * This is used in case there is a registered unnamed core (aka name is "") to
   * declare an alternate way of accessing named cores.
   * This can also be used in a pseudo single-core environment so admins can 
prepare
   * a new version before swapping.
   * @param path
   */
{code}

But the code is:

{code}
        // check for management path
        String alternate = cores.getManagementPath();
        if (alternate != null && path.startsWith(alternate)) {
          path = path.substring(0, alternate.length());
        }
{code}

This simply checks if the path starts with your management path (say /manage), 
and then sets the path to the management path - I don't see how this triggers 
or does anything later though...

Does anyone out there use this or know what if it does/did work? Perhaps it 
should just go away.

> Make SolrDispatchFilter testable and add tests
> ----------------------------------------------
>
>                 Key: SOLR-2633
>                 URL: https://issues.apache.org/jira/browse/SOLR-2633
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 3.1, 3.2, 3.3
>            Reporter: Edoardo Tosca
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: 3.4, 4.0
>
>         Attachments: SOLR-2633-tests-only.patch, SOLR-2633-tests-only.patch
>
>
> I have ideas for possible extensions/enhancements to the SolrDispatchFilter. 
> However, as it doesn't have any tests, making safe enhancements is difficult. 
> Given its monolithic nature, it is hard to test. Therefore, I am proposing to 
> refactor it to make it testable, and to provide tests for it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to