[ 
https://issues.apache.org/jira/browse/SOLR-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062222#comment-13062222
 ] 

Hoss Man commented on SOLR-2633:
--------------------------------

the change to a filter was in SOLR-104

some of the history may be spelled out there, or on the mailing list arround 
the same time, but i believe the crux of hte issue was wanting to ensure we 
could support dispatching to request handlers using path basd names (ie: 
http://host:8983/solr/admin/foo -> <requestHandler name="/admin/foo"/>) and 
still allow fallthrough to other jsps / servlets if a requestHandler with teh 
specified name couldn't be found.

using a Filter made this a little saner as i recall, and when multicore support 
was added, gave us the added bonus of being able to ensure that jsps could be 
used even when the base path was the core name.


> Make SolrDispatchFilter testable and add tests
> ----------------------------------------------
>
>                 Key: SOLR-2633
>                 URL: https://issues.apache.org/jira/browse/SOLR-2633
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 3.1, 3.2, 3.3
>            Reporter: Edoardo Tosca
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: 3.4, 4.0
>
>         Attachments: SOLR-2633-tests-only.patch, SOLR-2633-tests-only.patch
>
>
> I have ideas for possible extensions/enhancements to the SolrDispatchFilter. 
> However, as it doesn't have any tests, making safe enhancements is difficult. 
> Given its monolithic nature, it is hard to test. Therefore, I am proposing to 
> refactor it to make it testable, and to provide tests for it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to