[
https://issues.apache.org/jira/browse/SOLR-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062033#comment-13062033
]
David Smiley commented on SOLR-2633:
------------------------------------
I think it's great that this issue is going to make it more testable. But why
is SolrDispatchFilter a filter in the first place instead of a Servlet? This is
somewhat off-topic, but if perhaps it should be a servlet then this issue is
majorly disrupted by such a change.
> Make SolrDispatchFilter testable and add tests
> ----------------------------------------------
>
> Key: SOLR-2633
> URL: https://issues.apache.org/jira/browse/SOLR-2633
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 3.1, 3.2, 3.3
> Reporter: Edoardo Tosca
> Assignee: Mark Miller
> Priority: Minor
> Fix For: 3.4, 4.0
>
> Attachments: SOLR-2633-tests-only.patch, SOLR-2633-tests-only.patch
>
>
> I have ideas for possible extensions/enhancements to the SolrDispatchFilter.
> However, as it doesn't have any tests, making safe enhancements is difficult.
> Given its monolithic nature, it is hard to test. Therefore, I am proposing to
> refactor it to make it testable, and to provide tests for it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
