[
https://issues.apache.org/jira/browse/LUCENE-8469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596713#comment-16596713
]
Dawid Weiss commented on LUCENE-8469:
-------------------------------------
Updated the patch. I don't like the duplication in arguments (same
subexpressions), but it'd require an explicit pull of a local variable(s) for
each and every occurrence. The compiler should handle these efficiently and I
wouldn't want to make a mistake somewhere in there.
> Inline calls to the deprecated StringHelper.compare
> ---------------------------------------------------
>
> Key: LUCENE-8469
> URL: https://issues.apache.org/jira/browse/LUCENE-8469
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Trivial
> Fix For: 7.5
>
> Attachments: LUCENE-8469.patch, LUCENE-8469.patch
>
>
> In an attempt to limit the number of warnings during compilation I though
> it'd be nice to clean up our own stuff. This is a start: StringHelper.compare
> is used throughout the code and is delegated to FutureArrays (where it
> belongs, as the arguments are byte[], not Strings).
> This can cause other patches to not apply anymore... so we could apply this
> to master only. If anybody has a strong feeling about it, please voice it.
> The patch is trivial.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
