[
https://issues.apache.org/jira/browse/LUCENE-8469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598386#comment-16598386
]
Uwe Schindler commented on LUCENE-8469:
---------------------------------------
Hi,
I am fine with backporting. I understood Adrien's comment that he only wants to
do this in master. But he just meant deprecation vs. removal. So for 7.x we
should maybe deprecate, but as StringHelper is a private API (isnt it
documented as unstable) I am also fine with completely remove it.
About this issue: Nevertheless, while adding the FutureObjects/Arrays stuff
with Robert half a year ago, there were more places where we only have
delegator methods. In LZ4.java (compressing stored fields), we can also remove
one method, as it just calls a FutureArrays method without much parameter
mapping (only order of params and the usual length vs. end offset calc). So it
would be good to check all calls to FutureObjects/FutureArrays and remove
useless methods. Makes also code cleaner to read! And hotspot uses the
intrinsic earlier while optimizing.
> Inline calls to the deprecated StringHelper.compare
> ---------------------------------------------------
>
> Key: LUCENE-8469
> URL: https://issues.apache.org/jira/browse/LUCENE-8469
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Trivial
> Fix For: 7.5
>
> Attachments: LUCENE-8469.patch, LUCENE-8469.patch
>
>
> In an attempt to limit the number of warnings during compilation I though
> it'd be nice to clean up our own stuff. This is a start: StringHelper.compare
> is used throughout the code and is delegated to FutureArrays (where it
> belongs, as the arguments are byte[], not Strings).
> This can cause other patches to not apply anymore... so we could apply this
> to master only. If anybody has a strong feeling about it, please voice it.
> The patch is trivial.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
