[
https://issues.apache.org/jira/browse/LUCENE-8469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597107#comment-16597107
]
Dawid Weiss commented on LUCENE-8469:
-------------------------------------
The way I typically work (cherry-picking commits from master to branch_xx) it's
actually easier to apply this change to both (all) branches at the same time --
this makes those branches consistent for all future patches.
A conflict may arise only if somebody has been working on something (largeish)
and there are regions that overlap. Even in such a case resolving the conflict
shouldn't be much of a headache (it's a one-liner).
So I don't think it's really a huge problem, but if you'd rather keep it on
master only let me know, Uwe.
> Inline calls to the deprecated StringHelper.compare
> ---------------------------------------------------
>
> Key: LUCENE-8469
> URL: https://issues.apache.org/jira/browse/LUCENE-8469
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Trivial
> Fix For: 7.5
>
> Attachments: LUCENE-8469.patch, LUCENE-8469.patch
>
>
> In an attempt to limit the number of warnings during compilation I though
> it'd be nice to clean up our own stuff. This is a start: StringHelper.compare
> is used throughout the code and is delegated to FutureArrays (where it
> belongs, as the arguments are byte[], not Strings).
> This can cause other patches to not apply anymore... so we could apply this
> to master only. If anybody has a strong feeling about it, please voice it.
> The patch is trivial.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
