Github user iverase commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/451#discussion_r217971501
--- Diff: lucene/core/src/test/org/apache/lucene/util/bkd/TestBKD.java ---
@@ -1063,7 +1064,7 @@ public void testWastedLeadingBytes() throws Exception
{
Directory dir = newFSDirectory(createTempDir());
int numDocs = 100000;
- BKDWriter w = new BKDWriter(numDocs+1, dir, "tmp", numDims,
bytesPerDim, 32, 1f, numDocs, true);
+ BKDWriter w = new BKDWriter(numDocs+1, dir, "tmp", numDims, numDims,
bytesPerDim, 32, 1f, numDocs, true);
--- End diff --
Couldn't we add a mode on the random tests where dataDim != indexedDim. The
test can only check that the data dims are properly propagated to the leaf
nodes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
