Github user iverase commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/451#discussion_r220196714
--- Diff: lucene/core/src/test/org/apache/lucene/util/bkd/TestBKD.java ---
@@ -1063,7 +1064,7 @@ public void testWastedLeadingBytes() throws Exception
{
Directory dir = newFSDirectory(createTempDir());
int numDocs = 100000;
- BKDWriter w = new BKDWriter(numDocs+1, dir, "tmp", numDims,
bytesPerDim, 32, 1f, numDocs, true);
+ BKDWriter w = new BKDWriter(numDocs+1, dir, "tmp", numDims, numDims,
bytesPerDim, 32, 1f, numDocs, true);
--- End diff --
Thanks @nknize!
Would it be possible to add the following assertion in the method for
IntersectVisitor#visit. That would signal that we are propagating the index and
data dimensions to the method?
```
byte[][] expectedDocs = docValues[docID];
for (int dim =0; dim < numDataDims; dim++) {
assertTrue(FutureArrays.compareUnsigned(packedValue, dim *
numBytesPerDim, dim * numBytesPerDim + numBytesPerDim, expectedDocs[dim], 0,
numBytesPerDim) == 0);
}
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
