Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/500#discussion_r234535812
--- Diff:
lucene/test-framework/src/java/org/apache/lucene/analysis/ValidatingTokenFilter.java
---
@@ -50,6 +53,9 @@
private final OffsetAttribute offsetAtt =
getAttribute(OffsetAttribute.class);
private final CharTermAttribute termAtt =
getAttribute(CharTermAttribute.class);
+ // record all the Tokens seen so they can be dumped on failure
+ private final List<Token> tokens = new ArrayList<>();
--- End diff --
I slightly worry here that we are exposing ourselves to spurious
out-of-memory failures during testRandomStrings() or similar; can we maybe
limit this to just the last 200 tokens or something like that?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
