Github user romseygeek commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/500#discussion_r234535890
  
    --- Diff: 
lucene/test-framework/src/java/org/apache/lucene/analysis/ValidatingTokenFilter.java
 ---
    @@ -50,6 +53,9 @@
       private final OffsetAttribute offsetAtt = 
getAttribute(OffsetAttribute.class);
       private final CharTermAttribute termAtt = 
getAttribute(CharTermAttribute.class);
     
    +  // record all the Tokens seen so they can be dumped on failure
    +  private final List<Token> tokens = new ArrayList<>();
    --- End diff --
    
    This also needs to be emptied on `reset()`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to