Github user msokolov commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/500#discussion_r234606790
--- Diff:
lucene/test-framework/src/java/org/apache/lucene/analysis/ValidatingTokenFilter.java
---
@@ -50,6 +53,9 @@
private final OffsetAttribute offsetAtt =
getAttribute(OffsetAttribute.class);
private final CharTermAttribute termAtt =
getAttribute(CharTermAttribute.class);
+ // record all the Tokens seen so they can be dumped on failure
+ private final List<Token> tokens = new ArrayList<>();
--- End diff --
Oh I hadn't realized RandomChains could create such large strings that
would be a concern! Yes, I don't think it's helpful to have even 200 tokens
printed out. In general your interest here will be in the final few tokens, so
I think we can limit to 20 or so.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
