[
https://issues.apache.org/jira/browse/LUCENE-8611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725446#comment-16725446
]
Steve Rowe commented on LUCENE-8611:
------------------------------------
The addition of the {{hamcrest-core}} dependency to the
{{lucene-test-framework}} module under this issue has broken test compilation
under the Maven build, which -- unlike the Ant build -- enforces that all
modules depend intransitively on that module (along with all others).
I've attached a patch that fixes the problem. The grandparent pom, which hosts
the {{<dependencyManagement>}} section, has each module's dependencies rendered
intransitive by listing each of its dependencies in a nested {{<exclusions>}}
section. The attached patch modifies the custom {{mvndeps}} Ant task's
{{GetMavenDependenciesTask}} to allow modules to have transitive dependencies,
by NOT writing out the aforementioned nested {{<exclusions>}} section in the
grandparent pom; only the {{lucene-test-framework}} module is granted this
ability in the patch.
The patch fixes Maven compilation. If there are no objections, I'll commit
tomorrow.
BTW as of Maven 3.2.1, it's possible to use a wildcard syntax to exclude all
transitive deps: MNG-2315. That would make the grandparent pom much smaller
and make the intent much clearer. We would have to increase our minimum
supported Maven (currently 2.2.1), but that seems reasonable, given that Maven
2.x has been EOL'd: https://maven.apache.org/maven-2.x-eol.html
> Update randomizedtesting to 2.7.2, JUnit to 4.12, add hamcrest-core dependency
> ------------------------------------------------------------------------------
>
> Key: LUCENE-8611
> URL: https://issues.apache.org/jira/browse/LUCENE-8611
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 7.7
>
> Attachments: LUCENE-8611-fix-maven.patch, LUCENE-8611.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
