[ 
https://issues.apache.org/jira/browse/LUCENE-8611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725911#comment-16725911
 ] 

Steve Rowe commented on LUCENE-8611:
------------------------------------

bq. I'm also thinking that it really makes sense to require a newer version of 
Maven – plugins in those old versions don't support newer Java anyway and I 
don't think there are many benefits of staying with such an old version if a 
new one is available.

+1: LUCENE-8616

bq. I had an alternate fix which was to explicitly add hamcrest dependencies to 
all the various ivy.xml files which now have a dependency on it

Thanks Daniel for noticing and working on a fix.  I considered this ^^, but 
then as other modules start to need hamcrest-core, there would be more build 
failures like this, since the Ant build, used by the vast majority of devs, 
works without the explicit dependency.  I considered adding the dep to *all* 
modules, but at that point, the intent was clear to me: all users of 
{{lucene-test-framework}} should be able to depend on all its functionality 
without having to declare extra stuff, which is exactly what transitive 
dependency does.

bq. Does this patch apply to both branch_7x and master?

Yes, but I've just committed it both places.

> Update randomizedtesting to 2.7.2, JUnit to 4.12, add hamcrest-core dependency
> ------------------------------------------------------------------------------
>
>                 Key: LUCENE-8611
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8611
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 7.7
>
>         Attachments: LUCENE-8611-fix-maven.patch, LUCENE-8611.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to