[
https://issues.apache.org/jira/browse/LUCENE-8911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16885010#comment-16885010
]
Uwe Schindler commented on LUCENE-8911:
---------------------------------------
Hi [~tomoko],
sorry for the delay (was in "weekend mode"). The changes look fine, that's
exactly how I thought about it. It's good that the original names is only
modified if the legacy name is not yet in the map, so we don't get duplicate
names with just different spelling. Just to confirm: The generated names are
all lower case, right? So if there is a factory with no NAME field, it would
produce a lowercase only entry in both (map and set).
+1
Should we get this into 8.2 or not?
> Backport LUCENE-8778 (improved analysis SPI name handling) to 8.x
> -----------------------------------------------------------------
>
> Key: LUCENE-8911
> URL: https://issues.apache.org/jira/browse/LUCENE-8911
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
> Reporter: Tomoko Uchida
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In LUCENE-8907 I reverted LUCENE-8778 from the 8x branch.
> Can we backport it to 8x branch again, with transparent backwards
> compatibility (by emulating the factory loading method of Lucene 8.1)?
> I am not so sure about it would be better or not to backport the changes,
> however, maybe it is good for Solr to have SOLR-13593 without waiting for
> release 9.0.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
