[ 
https://issues.apache.org/jira/browse/LUCENE-8911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16885204#comment-16885204
 ] 

Tomoko Uchida commented on LUCENE-8911:
---------------------------------------

Thanks [~thetaphi],
{quote}Just to confirm: The generated names are all lower case, right? So if 
there is a factory with no NAME field, it would produce a lowercase only entry 
in both (map and set).
{quote}
Yes, I just copied the code which generates names from 8.1 branch as-is, so 
they are all lowercased.
{code:java}
name = clazzName.substring(0, clazzName.length() - 
suffix.length()).toLowerCase(Locale.ROOT);
{code}
{quote}Should we get this into 8.2 or not?
{quote}
I didn't think of merging it to the 8.2 branch again since it is now "on 
feature freeze" (as announced in the dev-list) and I am okay with we will delay 
this until 8.3..., any thoughts?

> Backport LUCENE-8778 (improved analysis SPI name handling) to 8.x
> -----------------------------------------------------------------
>
>                 Key: LUCENE-8911
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8911
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/analysis
>            Reporter: Tomoko Uchida
>            Priority: Minor
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In LUCENE-8907 I reverted LUCENE-8778 from the 8x branch.
> Can we backport it to 8x branch again, with transparent backwards 
> compatibility (by emulating the factory loading method of Lucene 8.1)?
> I am not so sure about it would be better or not to backport the changes, 
> however, maybe it is good for Solr to have SOLR-13593 without waiting for 
> release 9.0.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to