[ 
https://issues.apache.org/jira/browse/SOLR-2758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103349#comment-13103349
 ] 

Chris Male commented on SOLR-2758:
----------------------------------

Hey David,

Since FastLRUCache is in search.*, perhaps ConcurrentLRUCache should be to? for 
consistency sake.

I also couldn't get your patch to apply from either commandline or IntelliJ due 
to inconsistencies in the class level comments in FastLRUCache. 

> ConcurrentLRUCache should move from common/util to solr/util
> ------------------------------------------------------------
>
>                 Key: SOLR-2758
>                 URL: https://issues.apache.org/jira/browse/SOLR-2758
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>    Affects Versions: 3.3
>            Reporter: David Smiley
>            Priority: Minor
>         Attachments: SOLR-2758_move_ConcurrentLRUCache.patch
>
>
> There is exactly one small dependency that the SolrJ jar has to lucene-core 
> and that is indirectly via ConcurrentLRUCache which is in common/util.  SolrJ 
> doesn't even use this cache but it's there any way.  Attached is a patch for 
> the move. It also removes the lucene-core dependency that the SolrJ maven 
> pom.xml has on lucene-core.
> Steve Rowe agrees:
> https://issues.apache.org/jira/browse/SOLR-2756?focusedCommentId=13103103&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13103103

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to