[
https://issues.apache.org/jira/browse/SOLR-2758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104586#comment-13104586
]
Steven Rowe edited comment on SOLR-2758 at 9/14/11 3:54 PM:
------------------------------------------------------------
When I applied the patch (using the 'patch' utility), the file movement didn't
happen, so I modified the patch to depend on this svn script having been
already run:
{noformat}
svn mv solr/solrj/src/java/org/apache/solr/common/util/ConcurrentLRUCache.java
solr/core/src/java/org/apache/solr/util/
{noformat}
(I generated the patch with {{svn --no-diff-deleted diff > ...}}, so that the
source file's contents wouldn't be needlessly included in the patch.)
Also, I added a CHANGES.txt entry.
I plan on committing this shortly.
was (Author: steve_rowe):
When I applied the patch (using the 'patch' utility), the file movement
didn't happen, so I modified the patch to depend on the this svn script having
been already run:
{noformat}
svn mv solr/solrj/src/java/org/apache/solr/common/util/ConcurrentLRUCache.java
solr/core/src/java/org/apache/solr/util/
{noformat}
(I generated the patch with {{svn --no-diff-deleted diff > ...}}, so that the
source file's contents wouldn't be needlessly included in the patch.)
Also, I added a CHANGES.txt entry.
I plan on committing this shortly.
> ConcurrentLRUCache should move from common/util to solr/util
> ------------------------------------------------------------
>
> Key: SOLR-2758
> URL: https://issues.apache.org/jira/browse/SOLR-2758
> Project: Solr
> Issue Type: Improvement
> Components: clients - java
> Affects Versions: 3.3
> Reporter: David Smiley
> Assignee: Steven Rowe
> Priority: Minor
> Attachments: SOLR-2758_move_ConcurrentLRUCache.patch,
> SOLR-2758_move_ConcurrentLRUCache.patch,
> SOLR-2758_move_ConcurrentLRUCache.patch
>
>
> There is exactly one small dependency that the SolrJ jar has to lucene-core
> and that is indirectly via ConcurrentLRUCache which is in common/util. SolrJ
> doesn't even use this cache but it's there any way. Attached is a patch for
> the move. It also removes the lucene-core dependency that the SolrJ maven
> pom.xml has on lucene-core.
> Steve Rowe agrees:
> https://issues.apache.org/jira/browse/SOLR-2756?focusedCommentId=13103103&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13103103
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
