[
https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16892820#comment-16892820
]
Nicholas Knize commented on LUCENE-8369:
----------------------------------------
{quote}Such core use cases should work easily for users without wading thru
extra jars, third party dependencies, crazy licensing, or crazy class
hierarchies.
{quote}
I agree. That's why the `spatial` module should remain dependency free and
apache licensed.
{quote}I don't think adding esoteric functionality (like non-WGS shapes)
{quote}
Except esoteric is in the eye of the beholder so claiming someone will
understand or prefer latitude longitude search any more than basic x, y is
assumptive.
{quote}My fear of having LatLonPoint in a different package to other spatial
fields is code sharing
{quote}
I agree. When we only had LatLonPoint I leaned toward it moving to the spatial
module because of how we could advance the foundation. But since we weren't
there yet, I could understand the argument for having "...basic functionality
in core that solves the 90% geo use case". Now we've added geo shapes and a
cartesian coordinate system and it's quickly becoming a fragmentation issue
impeding development. IMHO it's clearer and cleaner for the dependency free
spatial code to all exist together in the same module called {{spatial}}. Is
there any technical downside or argument against removing it from core? Or is
it all a matter of opinion?
> Remove the spatial module as it is obsolete
> -------------------------------------------
>
> Key: LUCENE-8369
> URL: https://issues.apache.org/jira/browse/LUCENE-8369
> Project: Lucene - Core
> Issue Type: Task
> Components: modules/spatial
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Major
> Attachments: LUCENE-8369.patch
>
>
> The "spatial" module is at this juncture nearly empty with only a couple
> utilities that aren't used by anything in the entire codebase --
> GeoRelationUtils, and MortonEncoder. Perhaps it should have been removed
> earlier in LUCENE-7664 which was the removal of GeoPointField which was
> essentially why the module existed. Better late than never.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
