[
https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16893211#comment-16893211
]
Nicholas Knize commented on LUCENE-8369:
----------------------------------------
{quote}Can we simply make the necessary APIs public and marked
{{@lucene.internal}} in our core spatial classes?
{quote}
I think that's what we were trying to avoid because it largely feels like a cop
out to making a foundation class package private vice keeping it exposed. One
example is {{EdgeTree}} this can (and probably should) stay package private to
{{org.apache.lucene.geo}}. But it's used for {{XYShape}}, {{LatLonShape}}, and
{{LatLonPoint}}. So if we fragment those classes between the {{core}} and
{{spatial}} module we are forcing ourselves to keep it public and mark it
{{@lucene.internal}}. Which, again, feels like a cop out to doing (in my
opinion) the "right" thing and making it package private.
> Remove the spatial module as it is obsolete
> -------------------------------------------
>
> Key: LUCENE-8369
> URL: https://issues.apache.org/jira/browse/LUCENE-8369
> Project: Lucene - Core
> Issue Type: Task
> Components: modules/spatial
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Major
> Attachments: LUCENE-8369.patch
>
>
> The "spatial" module is at this juncture nearly empty with only a couple
> utilities that aren't used by anything in the entire codebase --
> GeoRelationUtils, and MortonEncoder. Perhaps it should have been removed
> earlier in LUCENE-7664 which was the removal of GeoPointField which was
> essentially why the module existed. Better late than never.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
