jimczi commented on a change in pull request #823: LUCENE-8939: Introduce
Shared Count Early Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#discussion_r318562576
##########
File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java
##########
@@ -414,6 +428,45 @@ public static TopFieldCollector create(Sort sort, int
numHits, FieldDoc after,
}
}
+ /**
+ * Same as above with an additional parameter to allow passing in the
threshold checker
+ */
+ public static TopFieldCollector create(Sort sort, int numHits, FieldDoc
after,
+ int totalHitsThreshold,
HitsThresholdChecker hitsThresholdChecker) {
Review comment:
We don't need the `totalHitsThreshold` here, is it possible to move the
argument validation (totalHitsThreshold < 0) in the HitsThresholdChecker ctr ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
