jimczi commented on a change in pull request #823: LUCENE-8939: Introduce
Shared Count Early Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#discussion_r319030989
##########
File path: lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java
##########
@@ -469,7 +469,7 @@ public TopDocs searchAfter(ScoreDoc after, Query query,
int numHits) throws IOEx
@Override
public TopScoreDocCollector newCollector() throws IOException {
- return TopScoreDocCollector.create(cappedNumHits, after,
TOTAL_HITS_THRESHOLD);
+ return TopScoreDocCollector.create(cappedNumHits, after, new
GlobalHitsThresholdChecker(TOTAL_HITS_THRESHOLD));
Review comment:
The `HitsThresholdChecker` should be created once and shared within the
collectors ? We also don't need to use the `GlobalHitsThresholdChecker` if the
executor is null or if there is a single slice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
