jimczi commented on a change in pull request #823: LUCENE-8939: Introduce
Shared Count Early Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#discussion_r318562876
##########
File path:
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java
##########
@@ -207,16 +210,23 @@ public static TopScoreDocCollector create(int numHits,
ScoreDoc after, int total
}
}
- final int totalHitsThreshold;
ScoreDoc pqTop;
+ final HitsThresholdChecker hitsThresholdChecker;
// prevents instantiation
- TopScoreDocCollector(int numHits, int totalHitsThreshold) {
+ TopScoreDocCollector(int numHits, int totalHitsThreshold,
HitsThresholdChecker hitsThresholdChecker) {
Review comment:
`totalHitsThreshold` is not needed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
