I found the bug, it's a stupid one: The line splitter is: def singleLineSplitter = ~$/\n\r?/$;
But should be (as it's \r\n on windows not the other way round): def singleLineSplitter = ~$/\r?\n/$; I'll commit the fix. It's just plain wrong! Uwe ----- Uwe Schindler Achterdiek 19, D-28357 Bremen https://www.thetaphi.de eMail: u...@thetaphi.de > -----Original Message----- > From: Dawid Weiss <dawid.we...@gmail.com> > Sent: Sunday, January 26, 2020 11:35 AM > To: Uwe Schindler <u...@thetaphi.de> > Cc: gerlowsk...@gmail.com; Lucene Dev <dev@lucene.apache.org>; Cassandra > Targett <casstarg...@gmail.com>; md...@apache.org > Subject: Re: analytics.adoc validation does not pass > > Maybe. But I truly hate when git tries to alter those line endings for > me... this hasn't been the first time I spent an hour looking at what > the hell is wrong between Windows/ Linux on the same checkout... > > D. > > On Sun, Jan 26, 2020 at 11:34 AM Uwe Schindler <u...@thetaphi.de> wrote: > > > > But we should nevertheless change the validator script to not fail on that. > > I > think the split by lines regex is problematic. > > > > Uwe > > > > Am January 26, 2020 10:31:11 AM UTC schrieb Dawid Weiss > <dawid.we...@gmail.com>: > >> > >> Sigh... It's because of the recent change to solr/.gitattributes > >> (SOLR-10713)... End of lines differ for adoc files. Jason -- please > >> change this one from auto to "don't touch line endings on any of other > >> files", whatever the magic is. > >> > >> # Handles all files not treated particularly below > >> * text=auto > >> > >> Dawid > >> > >> On Sun, Jan 26, 2020 at 11:20 AM Uwe Schindler <u...@thetaphi.de> > wrote: > >>> > >>> > >>> On Jenkins (Ant build) it only seems to happen on Windows. Which is > strange. > >>> > >>> Uwe > >>> > >>> Am January 26, 2020 10:13:44 AM UTC schrieb Dawid Weiss > <dawid.we...@gmail.com>: > >>>> > >>>> > >>>> Ok, I think it's the validation code at fault here. Mike -- would you > >>>> take a look at why the validation of solr-ref-guide doesn't pass? > >>>> There has to be a difference in infrastructure somewhere because we > >>>> use the same validation script... > >>>> > >>>> Dawid > >>>> > >>>> On Sun, Jan 26, 2020 at 10:55 AM Dawid Weiss > <dawid.we...@gmail.com> wrote: > >>>>> > >>>>> > >>>>> > >>>>> Hi Cassandra! > >>>>> > >>>>> I get this when running precommit on gradle build (gradlew > precommit): > >>>>> > >>>>>> Task :validateSourcePatterns > >>>>> > >>>>> > >>>>> [ant:groovy] Unescaped symbol "->" on line #43: > >>>>> solr/solr-ref-guide/src/analytics.adoc > >>>>> [ant:groovy] Unescaped symbol "->" on line #52: > >>>>> solr/solr-ref-guide/src/analytics.adoc > >>>>> > >>>>> I don't know if these are legitimate errors though or something that > >>>>> needs to be improved in validation code. > >>>>> > >>>>> Dawid > >>>> > >>>> ________________________________ > >>>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > >>>> For additional commands, e-mail: dev-h...@lucene.apache.org > >>>> > >>> > >>> -- > >>> Uwe Schindler > >>> Achterdiek 19, 28357 Bremen > >>> https://www.thetaphi.de > > > > > > -- > > Uwe Schindler > > Achterdiek 19, 28357 Bremen > > https://www.thetaphi.de --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
