I’m really struggling with what to do with compiler warnings, particularly all 
the rawtypes and unchecked warnings.

On the one hand, the simple mechanical thing to do would be to SuppressWarnings 
on each one that exists presently. Frankly that feels pretty useless; that 
would preserve poor code forever.

OTOH, actually _fixing_ the issues to not have, say, rawtypes is going to be 
time consuming and error-prone. Especially since I don’t really understand all 
the nuances yet and learning them one by one will introduce serious errors 
without doubt.

So here’s what I propose. Even though it feels useless, just SuppressWarnings 
on anything that’s not a simple fix. Then start failing builds on these 
warnings to catch any that come in in future. At least that way there’ll be 
some incentive to keep the code from getting _worse_, although people will 
still be able to just add SuppressWarnings to the mix I suppose.

The number of raw NamedList member variables we have is overwhelming all by 
itself….

Comments?


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to