Hi,

as always I did my smoke tests on Policeman Jenkins, this works:

SUCCESS! [0:27:39.140181]
(https://jenkins.thetaphi.de/job/Lucene-Release-Tester/8/console; tested with 
Java 11 and Java 17)

Unfortunately, I again found a module-system problem in combination with Luke 
(sorry in my personal opinion, this was way too early to release with module 
system support, we should have reverted the module system changes for 9.0!). 
The problem is the following: When using module system, sun.misc.Unsafe is not 
available (it contrast, it is avail in classpath mode by default). This causes 
Luke to never use MMapDirectory, because MMapDirectory disables itsself, as it 
cannot unmap (without sun.misc.Unsafe).

I will open a PR to fix this in later versions, also Dawids JMS branch needs to 
add the module to lucene-core's requires. To start Luke, you need to modify the 
startup script like this: java [...] --add-modules 
org.apache.logging.log4j,jdk.unsupported --module org.apache.lucene.luke

I don't want to hold the release, so still my +1, but in case of respoin please 
fix Luke startup. To use Luke, NIOFSDirectory is fine. Just not in production. 
So we should really tell people in release note that using Lucene 9.0 with 
module system is not supported!

Everything else looks fine, in the documentation we unfortunately did not merge 
the index.html changes (they are only in 9.x) to show correct path of Luke to 
start it.

+/-0 to release (so don't count a vote from me), in case of respin: fix 
activated modules for luke as stated above and fix index.html of documentation

Uwe
-----
Uwe Schindler
Achterdiek 19, D-28357 Bremen
https://www.thetaphi.de
eMail: [email protected]

> -----Original Message-----
> From: Adrien Grand <[email protected]>
> Sent: Wednesday, December 1, 2021 5:57 PM
> To: Lucene Dev <[email protected]>
> Subject: [VOTE] Release Lucene 9.0.0 RC4
> 
> Please vote for release candidate 4 for Lucene 9.0.0
> 
> The artifacts can be downloaded from:
> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.0.0-RC4-rev-
> 0b18b3b965cedaf5eb129aa41243a44c83ca826d
> 
> You can run the smoke tester directly with this command:
> 
> python3 -u dev-tools/scripts/smokeTestRelease.py \
> https://dist.apache.org/repos/dist/dev/lucene/lucene-9.0.0-RC4-rev-
> 0b18b3b965cedaf5eb129aa41243a44c83ca826d
> 
> The vote will be open until 2021-12-06 08:00 UTC.
> 
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)
> 
> Here is my +1
> 
> --
> Adrien
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to