[
https://issues.apache.org/jira/browse/LUCENE-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117306#comment-13117306
]
Robert Muir commented on LUCENE-3474:
-------------------------------------
Also, given the attitude presented here towards me uploading a *patch*
(threatening to revert my commits no matter what etc), you can be damned sure I
am going to be a total asshole about builder APIs.
By taking such a ridiculous stance on this internal API you have sealed the
fate of builders across the codebase.
Instead of looking at the actual use case and thinking 'does this need a
builder' you assume I'm completely against them: actually I don't have such a
blanket opinion: if you look at some classes I have added to lucene you will
see that I have even added builders myself... where it makes sense!
But just because a class has two booleans doesnt mean that it needs a Builder:
thats my problem, when you use a pattern as a hammer across the board like this
then it becomes an antipattern, because its the wrong solution.
In some cases Builder makes sense: I think just not here... but this doesn't
matter now. I'm gonna scream about builders now even when they really are a
good fit.
Nice work.
> pass liveDocs Bits down in scorercontext, instead of Weights pulling from the
> reader
> -------------------------------------------------------------------------------------
>
> Key: LUCENE-3474
> URL: https://issues.apache.org/jira/browse/LUCENE-3474
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-3474.patch, LUCENE-3474.patch
>
>
> Spinoff from LUCENE-1536, this would allow filters to work in a more flexible
> way (besides just cleaning up)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
