[ 
https://issues.apache.org/jira/browse/LUCENE-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117346#comment-13117346
 ] 

Robert Muir commented on LUCENE-3474:
-------------------------------------

{quote}
At the same time the benefits of the Contexts was that we could more easily 
make API changes. But perhaps with these classes some reluctance is beneficial?
{quote}

But I think this is a downside here, if we add some new flag (e.g. 
acceptedDocs) its important for you to change your code.
The context gives you a false warm-fuzzy feeling: pretend we already had 
ScorerContext and we committed this issue:
then your custom query continues to work fine, until you use a filter and its 
silently wrong!

{quote}
What would the signatures look like if we dumped ScorerContext?
{quote}

Like Lucene 3.x: IR, boolean, boolean, Bits
                
> pass liveDocs Bits down in scorercontext, instead of Weights pulling from the 
> reader 
> -------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3474
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3474
>             Project: Lucene - Java
>          Issue Type: Task
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>         Attachments: LUCENE-3474.patch, LUCENE-3474.patch
>
>
> Spinoff from LUCENE-1536, this would allow filters to work in a more flexible 
> way (besides just cleaning up)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to