[ 
https://issues.apache.org/jira/browse/LUCENE-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117342#comment-13117342
 ] 

Chris Male commented on LUCENE-3474:
------------------------------------

bq. This is interesting for discussion too: because a compile-time break is 
"better" than a runtime break I think in cases of changes to 
query/weight/scorer?

I agree.  The APIs of Query/Weight/Scorer feel to me to be so important that we 
should be very wary when making changes, but when we do want to make changes 
(and we should) then being explicit that something has changed and that people 
need to look carefully at the new API, seems beneficial.

At the same time the benefits of the Contexts was that we could more easily 
make API changes.  But perhaps with these classes some reluctance is beneficial?

What would the signatures look like if we dumped ScorerContext?
                
> pass liveDocs Bits down in scorercontext, instead of Weights pulling from the 
> reader 
> -------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3474
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3474
>             Project: Lucene - Java
>          Issue Type: Task
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>         Attachments: LUCENE-3474.patch, LUCENE-3474.patch
>
>
> Spinoff from LUCENE-1536, this would allow filters to work in a more flexible 
> way (besides just cleaning up)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to