[
https://issues.apache.org/jira/browse/SOLR-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134142#comment-13134142
]
James Dyer commented on SOLR-2848:
----------------------------------
finishStage() is being run on the Master Shard. It receives spelling results
from all of the shards and then has to integrate them together. Solr doesn't
return the scores with spelling suggestions back to the client. I suppose the
authors of SOLR-785 could have modified the response Solr sends back to its
clients. However, it probably seemed inexpensive enough to just re-compute the
string distance after-the-fact (indeed Lucene In Action 2nd ed sect 8.5.3
mentions doing the same thing, so I take it this is a common thing to do?).
The problem now we have is we've got a spellchecker that doesn't fully
implement a StringDistance all the time. I'd imagine the best bet is to try
and change that. Possibly, the slight discrepancies our current patch leave
are not serious enough to fix? If neither option is good, then we'd probably
have to modify the solr response to include scores.
> DirectSolrSpellChecker fails in distributed environment
> -------------------------------------------------------
>
> Key: SOLR-2848
> URL: https://issues.apache.org/jira/browse/SOLR-2848
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud, spellchecker
> Affects Versions: 4.0
> Reporter: James Dyer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-2848.patch
>
>
> While working on SOLR-2585, it was brought to my attention that
> DirectSolrSpellChecker has no test coverage involving a distributed
> environment. Here I am adding a random element to
> DistributedSpellCheckComponentTest to alternate between the "IndexBased" and
> "Direct" spell checkers. Doing so revealed bugs in using
> DirectSolrSpellChecker in a distributed environment. The fixes here roughly
> mirror those made to the "IndexBased" spell checker with SOLR-2083.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
