[ 
https://issues.apache.org/jira/browse/SOLR-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Dyer updated SOLR-2848:
-----------------------------

    Attachment: SOLR-2848-refactoring.patch

This version also contains refactorings to SpellCheckComponent.finishStage(), 
and moves the final merge to the SolrSpellChecker abstract class.

An alternative to doing this would be to keep the "mergeSuggestions()" method 
in SpellCheckComponent and simply implement "getStringDistance()" and 
"getAccuracy()" in SolrSpellChecker. 
                
> DirectSolrSpellChecker fails in distributed environment
> -------------------------------------------------------
>
>                 Key: SOLR-2848
>                 URL: https://issues.apache.org/jira/browse/SOLR-2848
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud, spellchecker
>    Affects Versions: 4.0
>            Reporter: James Dyer
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: SOLR-2848-refactoring.patch, SOLR-2848.patch, 
> SOLR-2848.patch
>
>
> While working on SOLR-2585, it was brought to my attention that 
> DirectSolrSpellChecker has no test coverage involving a distributed 
> environment.  Here I am adding a random element to 
> DistributedSpellCheckComponentTest to alternate between the "IndexBased" and 
> "Direct" spell checkers.  Doing so revealed bugs in using 
> DirectSolrSpellChecker in a distributed environment.  The fixes here roughly 
> mirror those made to the "IndexBased" spell checker with SOLR-2083.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to