[
https://issues.apache.org/jira/browse/SOLR-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147094#comment-13147094
]
Robert Muir commented on SOLR-2848:
-----------------------------------
Personally I really like your 2nd patch. I think its nice to open up merge()
like this.
Some ideas:
* I also think for now getStringDistance/getAccuracy need not return null? If
you don't support these methods, throw UOE instead and override merge(). we
document that this is how the default merge implementation works.
* Can we make getStringDistance/getAccuracy protected instead of public? We
don't want them to be suddenly get used by lots of other code when they are
really just a merge implementation detail.
* Is there any way to avoid this extra docFreq call when the spellchecker is
'sharded' ? Seems like we call docFreq twice in that case.
* I'd really like for a specific spellchecker impl to be able to able to work
with the default merge implementation etc without having 'boolean sharded' (it
shouldnt have to "know"). What is this extra check doing, and can we move it to
the base class?
> DirectSolrSpellChecker fails in distributed environment
> -------------------------------------------------------
>
> Key: SOLR-2848
> URL: https://issues.apache.org/jira/browse/SOLR-2848
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud, spellchecker
> Affects Versions: 4.0
> Reporter: James Dyer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: SOLR-2848-refactoring.patch, SOLR-2848.patch,
> SOLR-2848.patch
>
>
> While working on SOLR-2585, it was brought to my attention that
> DirectSolrSpellChecker has no test coverage involving a distributed
> environment. Here I am adding a random element to
> DistributedSpellCheckComponentTest to alternate between the "IndexBased" and
> "Direct" spell checkers. Doing so revealed bugs in using
> DirectSolrSpellChecker in a distributed environment. The fixes here roughly
> mirror those made to the "IndexBased" spell checker with SOLR-2083.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
