[ https://issues.apache.org/jira/browse/LUCENE-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150286#comment-13150286 ]
Shai Erera commented on LUCENE-3573: ------------------------------------ bq. This way there is no 3-way logic - either the TR was refreshed or it was not. +1. bq. And while we are at this, refresh() is void. I think it would be useful to return boolean, indicating whether any refresh took place. +1. > TaxonomyReader.refresh() is broken, replace its logic with reopen(), > following IR.reopen pattern > ------------------------------------------------------------------------------------------------ > > Key: LUCENE-3573 > URL: https://issues.apache.org/jira/browse/LUCENE-3573 > Project: Lucene - Java > Issue Type: Bug > Components: modules/facet > Reporter: Doron Cohen > Assignee: Doron Cohen > Priority: Minor > Attachments: LUCENE-3573.patch > > > When recreating the taxonomy index, TR's assumption that categories are only > added does not hold anymore. > As result, calling TR.refresh() will be incorrect at best, but usually throw > an AIOOBE. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org