[
https://issues.apache.org/jira/browse/LUCENE-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151089#comment-13151089
]
Shai Erera commented on LUCENE-3573:
------------------------------------
bq. DTW.rollback() seems wrong to me
I modified the method impl to call close() instead of refreshReader() and added
an appropriate test to DirTWTest to assert that following rollback, no more
actions are allowed on DirTW.
Separately, I think that we should add ensureOpen() to DirTW so that if you
call its API after rollback()/close(), you get a proper exception rather than
random exceptions (like NPE). I will open an issue for that (and cover the
rollback changes there too).
> TaxonomyReader.refresh() is broken, replace its logic with reopen(),
> following IR.reopen pattern
> ------------------------------------------------------------------------------------------------
>
> Key: LUCENE-3573
> URL: https://issues.apache.org/jira/browse/LUCENE-3573
> Project: Lucene - Java
> Issue Type: Bug
> Components: modules/facet
> Reporter: Doron Cohen
> Assignee: Doron Cohen
> Priority: Minor
> Attachments: LUCENE-3573.patch, LUCENE-3573.patch
>
>
> When recreating the taxonomy index, TR's assumption that categories are only
> added does not hold anymore.
> As result, calling TR.refresh() will be incorrect at best, but usually throw
> an AIOOBE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
