[ 
https://issues.apache.org/jira/browse/LUCENE-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151188#comment-13151188
 ] 

Doron Cohen commented on LUCENE-3573:
-------------------------------------

Hmm, now that there is a test for LTW.rollback() my changes fail LTW's 
testRollback() because LTW.close() now may call IW.commit(Map) (which it did 
not do before my changes).

For fixing this:
- added private doClose() which closes IW and nullifies it, and calls 
closeResources().
- rollback() calls doClose() instead of close().

Also, rollback() now made synchronized.
                
> TaxonomyReader.refresh() is broken, replace its logic with reopen(), 
> following IR.reopen pattern
> ------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3573
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3573
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: modules/facet
>            Reporter: Doron Cohen
>            Assignee: Doron Cohen
>            Priority: Minor
>         Attachments: LUCENE-3573.patch, LUCENE-3573.patch
>
>
> When recreating the taxonomy index, TR's assumption that categories are only 
> added does not hold anymore.
> As result, calling TR.refresh() will be incorrect at best, but usually throw 
> an AIOOBE.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to