[ 
https://issues.apache.org/jira/browse/LUCENE-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180253#comment-13180253
 ] 

Uwe Schindler commented on LUCENE-3628:
---------------------------------------

bq. I looked into this but subclasses override this and to tricky things like 
ParallelReader uses MultiNorms internally etc

This method could theoretically go (and must as final in IR). ParallelReader 
and SlowMultiReader will also delegate to normValues(), which internally uses 
MultiDocValues. This should behave identical and MultiNorms would be useless at 
all and could be deleted (that was the idea). *BUT:*

I think the problem is that MultiDocValues no longer has an array, so 
hasArray() returns false? If that's the case, I agree that we should leave it 
as it is for now and simply wait until norms() gets obsolete in a later issue.

Patch looks good!
                
> Cut Norms over to DocValues
> ---------------------------
>
>                 Key: LUCENE-3628
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3628
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: core/index, core/search
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 4.0
>
>         Attachments: LUCENE-3628.patch, LUCENE-3628.patch, LUCENE-3628.patch, 
> LUCENE-3628.patch, LUCENE-3628.patch
>
>
> since IR is now fully R/O and norms are inside codecs we can cut over to use 
> a IDV impl for writing norms. LUCENE-3606 has some 
> [ideas|https://issues.apache.org/jira/browse/LUCENE-3606?focusedCommentId=13160559&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13160559]
>  about how this could be implemented

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to