[
https://issues.apache.org/jira/browse/LUCENE-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180479#comment-13180479
]
Michael McCandless commented on LUCENE-3628:
--------------------------------------------
{quote}
bq.Though, why do we need to add the 3 per-type add methods...? Can we somehow
use the existing add that takes a DocValue...?
those were pulled up during refactoring. I added them to enable the default
merging. This patch marks them as protected so they are really an impl detail
and not a public API part.
{quote}
OK... really, ideally (I think?) the base "merge" method should only
use the public API (ie the very same API indexing/flushing uses when
writing a new segment). This is how our other base merge impls
(stored fields, term vectors, postings) work. But let's open a
separate issue for this...
bq. I also added a fix for the exception mike reported. I can't reproduce it
locally anymore.
Looks fixed -- I ran for 135 iterations and no fail (previously it
failed in first 10 or so...).
> Cut Norms over to DocValues
> ---------------------------
>
> Key: LUCENE-3628
> URL: https://issues.apache.org/jira/browse/LUCENE-3628
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/index, core/search
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Fix For: 4.0
>
> Attachments: LUCENE-3628.patch, LUCENE-3628.patch, LUCENE-3628.patch,
> LUCENE-3628.patch, LUCENE-3628.patch, LUCENE-3628.patch, LUCENE-3628.patch
>
>
> since IR is now fully R/O and norms are inside codecs we can cut over to use
> a IDV impl for writing norms. LUCENE-3606 has some
> [ideas|https://issues.apache.org/jira/browse/LUCENE-3606?focusedCommentId=13160559&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13160559]
> about how this could be implemented
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
