[
https://issues.apache.org/jira/browse/LUCENE-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simon Willnauer updated LUCENE-3628:
------------------------------------
Attachment: LUCENE-3628.patch
next iteration...
{quote}Though, why do
we need to add the 3 per-type add methods...? Can we somehow use the
existing add that takes a DocValue...? {quote}
those were pulled up during refactoring. I added them to enable the default
merging. This patch marks them as protected so they are really an impl detail
and not a public API part.
bq. The PerDocConsumer.pull seems a bit odd...
renamed to getDocValuesToMerge
bq. This change is curious:
I catch the exception there since its only the assert that triggers this so it
should not be part of the method signature. I wrapped it in a RuntimeEx in this
patch.
This patch also reduces the DocValue.java interface to gettters. the setters
are really part of the DocValuesField and are not needed inside the
implementation. Nobody should modify a DocValue instance. I also added a fix
for the exception mike reported. I can't reproduce it locally anymore.
> Cut Norms over to DocValues
> ---------------------------
>
> Key: LUCENE-3628
> URL: https://issues.apache.org/jira/browse/LUCENE-3628
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/index, core/search
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Fix For: 4.0
>
> Attachments: LUCENE-3628.patch, LUCENE-3628.patch, LUCENE-3628.patch,
> LUCENE-3628.patch, LUCENE-3628.patch, LUCENE-3628.patch, LUCENE-3628.patch
>
>
> since IR is now fully R/O and norms are inside codecs we can cut over to use
> a IDV impl for writing norms. LUCENE-3606 has some
> [ideas|https://issues.apache.org/jira/browse/LUCENE-3606?focusedCommentId=13160559&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13160559]
> about how this could be implemented
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
