[
https://issues.apache.org/jira/browse/LUCENE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235112#comment-13235112
]
Dawid Weiss commented on LUCENE-3877:
-------------------------------------
I don't like PMD that much either, I'm just saying it seems to have it. If I
were to choose though, I'd use aspectj rather than asm-based code. It just
seems cleaner to me.
{code}
public aspect NoSysOuts {
before(): within(org.apache.lucene..*) &&
get(static PrintStream System.*) {
throw new RuntimeException("Attempted sysout/syserr/sysin access.");
}
}
{code}
You don't even need to run it, just weave with verbose output and see if the
aspect matched anywhere.
> Lucene should not call System.out.println
> -----------------------------------------
>
> Key: LUCENE-3877
> URL: https://issues.apache.org/jira/browse/LUCENE-3877
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Michael McCandless
> Fix For: 3.6, 4.0
>
> Attachments: IllegalSystemTest.java, IllegalSystemTest.java,
> SystemPrintCheck.java
>
>
> We seem to have accumulated a few random sops...
> Eg, PairOutputs.java (oal.util.fst) and MultiDocValues.java, at least.
> Can we somehow detect (eg, have a test failure) if we accidentally leave
> errant System.out.println's (leftover from debugging)...?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
