[
https://issues.apache.org/jira/browse/LUCENE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235422#comment-13235422
]
Dawid Weiss commented on LUCENE-3877:
-------------------------------------
bq. I have seen it not work in the past for obscure reasons
Most likely the "reasons" were incorrect pointcut definitions? These can be
tricky, I agree. Nonetheless, I've been using AspectJ for a long time and it
always fits my needs and expectations. I'm not saying it doesn't have any bugs
-- I'm sure it has. But the right tool for the right job; it took me about 5
mins to write and apply that aspect (with follow ups, I sent an e-mail to the
mailing list, JIRA didn't work at the time).
I'm not advocating for any tool, really. To me aspectj is a fast tool for
expressing where I want a given snippet of code to be injected (or what I want
excluded) and for such tasks I don't see a faster or more pleasant to use
alternative. Oh, I've been using asmlib too; extensively in fact; so it's not
lack of knowledge about the tool itself.
> Lucene should not call System.out.println
> -----------------------------------------
>
> Key: LUCENE-3877
> URL: https://issues.apache.org/jira/browse/LUCENE-3877
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Michael McCandless
> Fix For: 3.6, 4.0
>
> Attachments: IllegalSystemTest.java, IllegalSystemTest.java,
> SystemPrintCheck.java
>
>
> We seem to have accumulated a few random sops...
> Eg, PairOutputs.java (oal.util.fst) and MultiDocValues.java, at least.
> Can we somehow detect (eg, have a test failure) if we accidentally leave
> errant System.out.println's (leftover from debugging)...?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
