[
https://issues.apache.org/jira/browse/LUCENE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235196#comment-13235196
]
Greg Bowyer commented on LUCENE-3877:
-------------------------------------
Well would it sway the argument if I said that the ASM code near directly
translates into a findbugs rule (I have done this before)
I was also not wanting to suggest findbug custom rules at the start because
thats a bigger change in including an entire code lint tool (unless its
included with lucene already, in which case forgive my stupidity I am still
finding my way around)
Something doesn't fit right in my mind with the AspectJ approach, I have seen
it not work in the past for obscure reasons and it feels that running the
weaving in pretend to check the verbose output is not much further on from
checking the source code in the first place.
> Lucene should not call System.out.println
> -----------------------------------------
>
> Key: LUCENE-3877
> URL: https://issues.apache.org/jira/browse/LUCENE-3877
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Michael McCandless
> Fix For: 3.6, 4.0
>
> Attachments: IllegalSystemTest.java, IllegalSystemTest.java,
> SystemPrintCheck.java
>
>
> We seem to have accumulated a few random sops...
> Eg, PairOutputs.java (oal.util.fst) and MultiDocValues.java, at least.
> Can we somehow detect (eg, have a test failure) if we accidentally leave
> errant System.out.println's (leftover from debugging)...?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
