[ 
https://issues.apache.org/jira/browse/LUCENE-4600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527356#comment-13527356
 ] 

Shai Erera commented on LUCENE-4600:
------------------------------------

Changing the title, which got me thinking -- Mike, if we do the Reader/DV 
caching approach, that could benefit post-collection performance too, right? Is 
it possile that you hack the current FacetsCollector to do the aggregation over 
CachedBytes and then compare the difference?

Because your first results show that during-collection are not that much faster 
than post-collection, I am just wondering if it'll be the same when we cache 
the bytes outside the collector entirely.

If so, I think it should push us to do this caching outside, because we've 
already identified cases where post-collection is needed (e.g. sampling) too.
                
> Explore facets aggregation during documents collection
> ------------------------------------------------------
>
>                 Key: LUCENE-4600
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4600
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>         Attachments: LUCENE-4600.patch, LUCENE-4600.patch
>
>
> Today the facet module simply gathers all hits (as a bitset, optionally with 
> a float[] to hold scores as well, if you will aggregate them) during 
> collection, and then at the end when you call getFacetsResults(), it makes a 
> 2nd pass over all those hits doing the actual aggregation.
> We should investigate just aggregating as we collect instead, so we don't 
> have to tie up transient RAM (fairly small for the bit set but possibly big 
> for the float[]).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to