[
https://issues.apache.org/jira/browse/LUCENE-4600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527512#comment-13527512
]
Michael McCandless commented on LUCENE-4600:
--------------------------------------------
bq. I would like to see one ordinals-store, I don't think that we should allow
either payload or DV. If DV lets us write byte[], and we could read it off-disk
or RAM, we should make the cut to DV.
+1, though we should test the on-disk DV vs current payloads to be sure.
bq. But note that DV means ugrading existing indexes.
Hmm it would be nice to somehow migrate on the fly ... not sure how.
bq. But if there's a clean way to do a one-time index upgrade to DV, then let's
just write it once, and then DVs are migratable, so that's another +1 for DV.
If we do the migrate-on-the-fly then users can use IndexUpgrader to migrate
entire index.
{quote}
Point is, this abstract layer should remain. I know that you're in the
exploration phase, but keep that in mind. In fact, if we're able to make the
cut to DV as an internal change, we could also benefit from the existing test
suite, to make sure everything's working.
{quote}
+1, the abstractions are nice an generic.
I'll test to see how much these abstraction are hurting the hotspots ... we can
always make/pick specialized collectors (like the patch) if necessary, and keep
generic collectors for the fully general cases ...
> Explore facets aggregation during documents collection
> ------------------------------------------------------
>
> Key: LUCENE-4600
> URL: https://issues.apache.org/jira/browse/LUCENE-4600
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Michael McCandless
> Attachments: LUCENE-4600.patch, LUCENE-4600.patch
>
>
> Today the facet module simply gathers all hits (as a bitset, optionally with
> a float[] to hold scores as well, if you will aggregate them) during
> collection, and then at the end when you call getFacetsResults(), it makes a
> 2nd pass over all those hits doing the actual aggregation.
> We should investigate just aggregating as we collect instead, so we don't
> have to tie up transient RAM (fairly small for the bit set but possibly big
> for the float[]).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
