[ 
https://issues.apache.org/jira/browse/LUCENE-4600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527436#comment-13527436
 ] 

Shai Erera commented on LUCENE-4600:
------------------------------------

Another point about DV - that's actually a design thing. One important hook is 
IntEncoder/Decoder. It determines how the fulltree is encoded/decoded. For 
example, you used one method (VInt+DGap), but there are other encoders. In one 
application, every document added almost unique facets and so the ordinals 
returned had a gap of 1-2. Therefore we have a FourOnes and EightOnes encoders.

Point is, this abstract layer should remain. I know that you're in the 
exploration phase, but keep that in mind. In fact, if we're able to make the 
cut to DV as an internal change, we could also benefit from the existing test 
suite, to make sure everything's working.
                
> Explore facets aggregation during documents collection
> ------------------------------------------------------
>
>                 Key: LUCENE-4600
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4600
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>         Attachments: LUCENE-4600.patch, LUCENE-4600.patch
>
>
> Today the facet module simply gathers all hits (as a bitset, optionally with 
> a float[] to hold scores as well, if you will aggregate them) during 
> collection, and then at the end when you call getFacetsResults(), it makes a 
> 2nd pass over all those hits doing the actual aggregation.
> We should investigate just aggregating as we collect instead, so we don't 
> have to tie up transient RAM (fairly small for the bit set but possibly big 
> for the float[]).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to