[ 
https://issues.apache.org/jira/browse/LUCENE-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605005#comment-13605005
 ] 

Michael Poindexter commented on LUCENE-4848:
--------------------------------------------

No problem, I'll produce a patch against trunk that just changes the existing 
directory implementations as little as possible.

Two questions:
1.)  Since this changes the file writing behavior for NIOFSDirectory and 
MMapDirectory (writes can now throw a ClosedChannelException if the thread is 
interrupted, where I believe they couldn't before) should the changes be 
controllable via a flag?  Or should I just not change how writes are done for 
these two classes (since it shouldn't be necessary to delete a file while it is 
open for write, only if it is open read)

2.)  I was using a Path instead of a File internally to represent the directory 
location.  This is somewhat nice in that it works with the Java 7 pluggable 
filesystems implementation (i.e. to zip up an index one could just use the zip 
filesystem provider with a directory and then do a Directory.copyTo).  I assume 
you want to not add a dependency on using a Path since that would change the 
return type of FSDirectory.getDirectory()?
                
> Add Directory implementations using NIO2 APIs
> ---------------------------------------------
>
>                 Key: LUCENE-4848
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4848
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Michael Poindexter
>            Assignee: Uwe Schindler
>            Priority: Minor
>         Attachments: jdk7directory.zip
>
>
> I have implemented 3 Directory subclasses using NIO2 API's (available on 
> JDK7).  These may be suitable for inclusion in a Lucene contrib module.
> See the mailing list at http://lucene.markmail.org/thread/lrv7miivzmjm3ml5 
> for more details about this code and the advantages it provides.
> The code is attached as a zip to this issue.  I'll be happy to make any 
> changes requested.  I've included some minimal smoke tests, but any help in 
> how to use the normal Lucene tests to perform more thorough testing would be 
> appreciated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to