[
https://issues.apache.org/jira/browse/LUCENE-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605015#comment-13605015
]
Uwe Schindler commented on LUCENE-4848:
---------------------------------------
About 2: I am fine with using Path. When we are on Java 7, Path is fine to hold
the pointer to the directory. Of course FSDirectory could add another ctor, but
not replace the File-based ones. I think you current code does the right thing.
About writing: I know, you changed the whole FSDirectory base class to use
Channel. Maybe keep the base class mostly as it is (with a generic "descriptor
parameter", that can be a RAF or Channel). I would prefer to make writing for
now use the RAF as before, but provide a channel-based impl, too?
About 1: The problem with interruptions is a bigger one - we should avoid that
any Directory implementation in Lucene is reacting to interruptions and produce
failures. We had lots of bug reports (regards a bug in Sun's original
implementation, that auto-closed a channel when interrupted). So in general,
interrupted file io in lucene should be repeated.
I will now setup Java 7 build for trunk and after short confirmation from the
mailing lists, I will move Lucene trunk's build to require Java 7!
> Add Directory implementations using NIO2 APIs
> ---------------------------------------------
>
> Key: LUCENE-4848
> URL: https://issues.apache.org/jira/browse/LUCENE-4848
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Michael Poindexter
> Assignee: Uwe Schindler
> Priority: Minor
> Attachments: jdk7directory.zip
>
>
> I have implemented 3 Directory subclasses using NIO2 API's (available on
> JDK7). These may be suitable for inclusion in a Lucene contrib module.
> See the mailing list at http://lucene.markmail.org/thread/lrv7miivzmjm3ml5
> for more details about this code and the advantages it provides.
> The code is attached as a zip to this issue. I'll be happy to make any
> changes requested. I've included some minimal smoke tests, but any help in
> how to use the normal Lucene tests to perform more thorough testing would be
> appreciated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
